chore: merge main into dev to apply changes from #91#98
Merged
Conversation
Change the sync issues workflow to run daily at 2:00 AM UTC and update the default target branch to 'dev'. Removed unnecessary branch determination logic for clarity. Refs: #91
## Summary - Changes cron schedule from `0 0 * * *` (midnight UTC) to `0 2 * * *` (2:00 AM UTC) - Removes event-based triggers (`issues` and `pull_request` events) — workflow now only runs on schedule or manual dispatch - Removes the dynamic `Determine target branch` step; branch is now taken directly from the `workflow_dispatch` input (`target-branch`, defaulting to `dev`) - Simplifies `target-branch` input description to reflect supported values (`dev`, `release/x.y.z`) Closes #91 ## Test plan (only possible after merge) - [ ] Verify workflow runs correctly on the daily schedule at 2:00 AM UTC - [ ] Trigger manually via `workflow_dispatch` without specifying a branch — confirm it checks out `dev` - [ ] Trigger manually via `workflow_dispatch` with a specific branch — confirm it checks out the specified branch Refs: #91
Resolve merge conflict in sync-issues.yml by keeping dev's security hardening (pinned SHAs, ubuntu-22.04, timeout, permissions) while applying main's trigger simplification (remove issues/PR events). Refs: #91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge
mainback intodevto synchronize changes that landed onmainvia #91:issuesandpull_requestevent triggers fromsync-issues.yml, keeping only the daily schedule (0 2 * * *) andworkflow_dispatch. Simplifies target branch logic by removing the now-unnecessary "Determine target branch" step.Conflict Resolution
The
devbranch had additional hardening changes tosync-issues.yml(pinned action SHAs,ubuntu-22.04,timeout-minutes, restrictive top-levelpermissions,output-dir: 'docs'). The merge conflict was resolved by keeping all ofdev's security hardening while applyingmain's trigger simplification.Supersedes #97 (which had an unresolvable conflict due to head being
mainitself).Tests
sync-issues.ymlworkflow no longer triggers on issue/PR eventsworkflow_dispatchwithtarget-branchinput still works (used byrelease.ymlandpost-release.yml)Refs: #91